Implement health checks for Azure AI Inference ChatCompletionsClient and EmbeddingsClient#15969
Open
Formatted wants to merge 1 commit intomicrosoft:mainfrom
Open
Conversation
…and EmbeddingsClient
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 15969Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 15969" |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ChatCompletionsClientandEmbeddingsClientregistrations inAspire.Azure.AI.InferencehadGetHealthCheckEnabledhardcoded tofalseandCreateHealthCheckthrowingNotImplementedException, meaning health checks were silently disabled for both client types regardless of configuration.This PR adds
AzureAIInferenceChatCompletionsHealthCheckandAzureAIInferenceEmbeddingsHealthCheck, which use the already-registered SDK clients to callGetModelInfoAsync()(a single read-only HTTP GET to/info), verifying endpoint connectivity. ADisableHealthChecksproperty is added toChatCompletionsClientSettingsto allow opt-out, consistent with theDisableMetrics/DisableTracingpattern. The conformance testSetHealthCheckoverride is also enabled.AzureOpenAIClienthealth checks remain disabled — theAzure.AI.OpenAISDK deliberately throwsNotSupportedExceptiononGetOpenAIModelClient(), and all other sub-clients require a deployment name and initiate real inference operations. The existingNotImplementedExceptionis replaced with aNotSupportedExceptionand an explanatory comment.Fixes # (issue) — N/A, addressing existing
NotImplementedException/ hardcodedfalseChecklist
SetHealthCheckconformance tests enabled forConformanceTestsinAspire.Azure.AI.Inference.TestsDisableHealthChecksonChatCompletionsClientSettingsDisableMetrics/DisableTracingpattern on the same type; no new design decisions<remarks />and<code />elements on your triple slash comments?